Refactor Export CSV button, Use ExportCsvButton component from commons-ui
#3274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remove local duplicated component Signed-off-by: sBouzols <[email protected]>
|
SlimaneAmar
approved these changes
Sep 22, 2025
sBouzols
merged commit 24db56d
into
fix_export_csv_export_button_status_at_node_rn_change
5 checks passed
sBouzols
deleted the
refactor_remove_ExportButton_use_ExportCsvButton_from_commons-ui
branch
sBouzols
added a commit
that referenced
this pull request
Sep 23, 2025
…3272) * fix(SA,SE,CC): reset `exportSuccessful` states when context like study, node or rootNetwork change as well as resultType, computation type or tab change. refactor(SE): move export CSV Button in a separeted component like for other computations * fix(SA, SE, CC): from review add `appTabIndex` trigger to reset export CSV button status * fix(SE): Add `sortConfig` trigger to reset export CSV button status, for other computation types results are invalidated when sorting then the button is disabled and trigger a status reset. * refactor(SA,SE,CC): use `ExportCsvButton` component from commons-ui, remove local duplicated component (#3274) Signed-off-by: sBouzols <[email protected]>
sBouzols
added a commit
that referenced
this pull request
Sep 23, 2025
* fix(SA,SE,CC): reset `export successful` states when button is disabled which happen when results change or computation status change. Remark: For other computation types (LF, State estim, Voltage init), we need more work in commons-ui on `CsvExport` component, to use `isDownloadLoading` and `isDownloadSuccessful` of the `ExportCsvButton` child component even if its direct export without backend requests * Fix Export CSV Button success status for SA,SE,CC at context change (#3272) * fix(SA,SE,CC): reset `exportSuccessful` states when context like study, node or rootNetwork change as well as resultType, computation type or tab change. refactor(SE): move export CSV Button in a separeted component like for other computations * fix(SA, SE, CC): from review add `appTabIndex` trigger to reset export CSV button status * fix(SE): Add `sortConfig` trigger to reset export CSV button status, for other computation types results are invalidated when sorting then the button is disabled and trigger a status reset. * refactor(SA,SE,CC): use `ExportCsvButton` component from commons-ui, remove local duplicated component (#3274) Signed-off-by: sBouzols <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(SA,SE,CC): use
ExportCsvButtoncomponent from commons-ui, remove local duplicated component